Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/browser/chromeos/system/timezone_util.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system/timezone_util.cc
diff --git a/chrome/browser/chromeos/system/timezone_util.cc b/chrome/browser/chromeos/system/timezone_util.cc
index be305fa9168b16c1690a27d25be7e1aa99cbdc34..067775f48b7cfa36fb3ea785d7a922f076759a32 100644
--- a/chrome/browser/chromeos/system/timezone_util.cc
+++ b/chrome/browser/chromeos/system/timezone_util.cc
@@ -6,10 +6,13 @@
#include <stddef.h>
+#include <memory>
#include <string>
+#include <utility>
#include "base/i18n/rtl.h"
#include "base/lazy_instance.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -152,11 +155,11 @@ std::unique_ptr<base::ListValue> GetTimezoneList() {
for (std::vector<icu::TimeZone*>::const_iterator iter = timezones.begin();
iter != timezones.end(); ++iter) {
const icu::TimeZone* timezone = *iter;
- base::ListValue* option = new base::ListValue();
- option->Append(new base::StringValue(
- chromeos::system::TimezoneSettings::GetTimezoneID(*timezone)));
- option->Append(new base::StringValue(GetTimezoneName(*timezone)));
- timezoneList->Append(option);
+ auto option = base::MakeUnique<base::ListValue>();
+ option->AppendString(
+ chromeos::system::TimezoneSettings::GetTimezoneID(*timezone));
+ option->AppendString(GetTimezoneName(*timezone));
+ timezoneList->Append(std::move(option));
}
return timezoneList;
}

Powered by Google App Engine
This is Rietveld 408576698