Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3701)

Unified Diff: chrome/browser/ui/ash/chrome_keyboard_ui.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_keyboard_ui.cc
diff --git a/chrome/browser/ui/ash/chrome_keyboard_ui.cc b/chrome/browser/ui/ash/chrome_keyboard_ui.cc
index 9bc61f035274910183a0e03e5a5b1ea94ccee719..07fcf9c09aa480d9c735b0bf8fb637f20e38bb21 100644
--- a/chrome/browser/ui/ash/chrome_keyboard_ui.cc
+++ b/chrome/browser/ui/ash/chrome_keyboard_ui.cc
@@ -95,7 +95,7 @@ class AshKeyboardControllerObserver
new_bounds->SetInteger("top", bounds.y());
new_bounds->SetInteger("width", bounds.width());
new_bounds->SetInteger("height", bounds.height());
- event_args->Append(new_bounds.release());
+ event_args->Append(std::move(new_bounds));
std::unique_ptr<extensions::Event> event(new extensions::Event(
extensions::events::VIRTUAL_KEYBOARD_PRIVATE_ON_BOUNDS_CHANGED,
@@ -233,7 +233,7 @@ void ChromeKeyboardUI::SetUpdateInputType(ui::TextInputType type) {
input_context->SetString("type",
virtual_keyboard_private::ToString(
TextInputTypeToGeneratedInputTypeEnum(type)));
- event_args->Append(input_context.release());
+ event_args->Append(std::move(input_context));
std::unique_ptr<extensions::Event> event(new extensions::Event(
extensions::events::VIRTUAL_KEYBOARD_PRIVATE_ON_TEXT_INPUT_BOX_FOCUSED,

Powered by Google App Engine
This is Rietveld 408576698