Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/ui/webui/options/preferences_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/preferences_browsertest.h"
 
 #include <stddef.h>
 
 #include <iostream>
 #include <memory>
 #include <sstream>
+#include <utility>
 
 #include "base/callback.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 727 matching lines @@
 
   // String pref.
   pref_names_.push_back(chromeos::kReleaseChannel);
   non_default_values_.push_back(new base::StringValue("stable-channel"));
   decorated_non_default_values.push_back(
       non_default_values_.back()->DeepCopy());
 
   // List pref.
   pref_names_.push_back(chromeos::kAccountsPrefUsers);
   base::ListValue* list = new base::ListValue;
-  list->Append(new base::StringValue("me@google.com"));
-  list->Append(new base::StringValue("you@google.com"));
+  list->AppendString("me@google.com");
+  list->AppendString("you@google.com");
   non_default_values_.push_back(list);
   list = new base::ListValue;
-  base::DictionaryValue* dict = new base::DictionaryValue;
+  auto dict = base::MakeUnique<base::DictionaryValue>();
   dict->SetString("username", "me@google.com");
   dict->SetString("name", "me@google.com");
   dict->SetString("email", "");
   dict->SetBoolean("owner", false);
-  list->Append(dict);
-  dict = new base::DictionaryValue;
+  list->Append(std::move(dict));
+  dict = base::MakeUnique<base::DictionaryValue>();
   dict->SetString("username", "you@google.com");
   dict->SetString("name", "you@google.com");
   dict->SetString("email", "");
   dict->SetBoolean("owner", false);
-  list->Append(dict);
+  list->Append(std::move(dict));
   decorated_non_default_values.push_back(list);
 
   chromeos::CrosSettings* cros_settings = chromeos::CrosSettings::Get();
   for (size_t i = 0; i < pref_names_.size(); ++i) {
     cros_settings->Set(pref_names_[i], *non_default_values_[i]);
   }
 
   // Verify notifications when mandatory values are in effect.
   SetupJavaScriptTestEnvironment(pref_names_, &observed_json);
   VerifyObservedPrefs(observed_json, pref_names_,
@@ skipping 158 matching lines @@
   pref_names_.push_back(chromeos::kProxySingleHttpPort);
   non_default_values_.push_back(new base::FundamentalValue(8080));
 
   // String pref.
   pref_names_.push_back(chromeos::kProxySingleHttp);
   non_default_values_.push_back(new base::StringValue("127.0.0.1"));
 
   // List pref.
   pref_names_.push_back(chromeos::kProxyIgnoreList);
   base::ListValue* list = new base::ListValue();
-  list->Append(new base::StringValue("*.google.com"));
-  list->Append(new base::StringValue("1.2.3.4:22"));
+  list->AppendString("*.google.com");
+  list->AppendString("1.2.3.4:22");
   non_default_values_.push_back(list);
 
   // Verify that no policy is presented to the UI. This must be verified on the
   // kProxyType and the kUseSharedProxies prefs.
   pref_names_.push_back(chromeos::kProxyType);
   non_default_values_.push_back(new base::FundamentalValue(2));
 
   pref_names_.push_back(prefs::kUseSharedProxies);
   non_default_values_.push_back(new base::FundamentalValue(false));
 
@@ skipping 115 matching lines @@
   SetProxyPref(chromeos::kProxyHttpsPort, base::FundamentalValue(2));
   SetProxyPref(chromeos::kProxyFtpPort, base::FundamentalValue(3));
   SetProxyPref(chromeos::kProxySocksPort, base::FundamentalValue(4));
 
   VerifyCurrentProxyServer(
       "http=a.com:1;https=4.3.2.1:2;ftp=c.com:3;socks=socks4://d.com:4",
       onc::ONC_SOURCE_NONE);
 }
 
 #endif