Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: chrome/browser/chromeos/file_manager/url_util.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/url_util.cc
diff --git a/chrome/browser/chromeos/file_manager/url_util.cc b/chrome/browser/chromeos/file_manager/url_util.cc
index e8f8bd67980e0b6507d60c0531de57dd554ca59e..035b46902f4dc15c245b304175f18694af71492b 100644
--- a/chrome/browser/chromeos/file_manager/url_util.cc
+++ b/chrome/browser/chromeos/file_manager/url_util.cc
@@ -89,8 +89,7 @@ GURL GetFileManagerMainPageUrlWithParams(
for (size_t i = 0; i < file_types->extensions.size(); ++i) {
base::ListValue* extensions_list = new base::ListValue();
for (size_t j = 0; j < file_types->extensions[i].size(); ++j) {
- extensions_list->Append(
- new base::StringValue(file_types->extensions[i][j]));
+ extensions_list->AppendString(file_types->extensions[i][j]);
}
base::DictionaryValue* dict = new base::DictionaryValue();

Powered by Google App Engine
This is Rietveld 408576698