Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/chromeos/settings/owner_flags_storage.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/owner_flags_storage.cc
diff --git a/chrome/browser/chromeos/settings/owner_flags_storage.cc b/chrome/browser/chromeos/settings/owner_flags_storage.cc
index 8b52ea83d5d37852ce633cf329dbbc96d7f4bfd3..d72e484d98d1fbb5966954079bb73520044dc367 100644
--- a/chrome/browser/chromeos/settings/owner_flags_storage.cc
+++ b/chrome/browser/chromeos/settings/owner_flags_storage.cc
@@ -37,7 +37,7 @@ bool OwnerFlagsStorage::SetFlags(const std::set<std::string>& flags) {
for (base::CommandLine::StringVector::const_iterator it =
switches.begin() + 1;
it != switches.end(); ++it) {
- experiments_list.Append(new base::StringValue(*it));
+ experiments_list.AppendString(*it);
}
owner_settings_service_->Set(kStartUpFlags, experiments_list);
« no previous file with comments | « chrome/browser/chromeos/settings/device_settings_provider_unittest.cc ('k') | chrome/browser/chromeos/system/timezone_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698