Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/wallpaper_api.cc
diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc
index 3d595d96e130765a4fd3e8c336fafb69f5b4514d..080f49db31706ec3ff5e0bdc94e75cfbf4fea147 100644
--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc
+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc
@@ -250,8 +250,8 @@ void WallpaperSetWallpaperFunction::ThumbnailGenerated(
std::unique_ptr<base::ListValue> event_args(new base::ListValue());
event_args->Append(original_result->DeepCopy());
event_args->Append(thumbnail_result->DeepCopy());
- event_args->Append(new base::StringValue(
- extensions::api::wallpaper::ToString(params_->details.layout)));
+ event_args->AppendString(
+ extensions::api::wallpaper::ToString(params_->details.layout));
// Setting wallpaper from right click menu in 'Files' app is a feature that
// was implemented in crbug.com/578935. Since 'Files' app is a built-in v1
// app in ChromeOS, we should treat it slightly differently with other third
@@ -259,10 +259,10 @@ void WallpaperSetWallpaperFunction::ThumbnailGenerated(
// and it should not appear in the wallpaper grid in the Wallpaper Picker.
// But we should not display the 'wallpaper-set-by-mesage' since it might
// introduce confusion as shown in crbug.com/599407.
- event_args->Append(new base::StringValue(
+ event_args->AppendString(
(extension()->id() == file_manager::kFileManagerAppId)
? std::string()
- : extension()->name()));
+ : extension()->name());
std::unique_ptr<extensions::Event> event(new extensions::Event(
extensions::events::WALLPAPER_PRIVATE_ON_WALLPAPER_CHANGED_BY_3RD_PARTY,
extensions::api::wallpaper_private::OnWallpaperChangedBy3rdParty::

Powered by Google App Engine
This is Rietveld 408576698