chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/platform_keys/key_permissions.cc ('k') | chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

index 722ebac55c91c65d7b96a9b6c3a3569a2edad3be..7c9f3bef29bb2d0af72b88c8e05e8b8d1015ad86 100644

--- a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

+++ b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

@@ -328,9 +328,9 @@ void PinnedLauncherAppsPolicyHandler::ApplyPolicySettings(

entry != policy_list->end(); ++entry) {

std::string id;

if ((*entry)->GetAsString(&id)) {

- base::DictionaryValue* app_dict = new base::DictionaryValue();

+ auto app_dict = base::MakeUnique<base::DictionaryValue>();

app_dict->SetString(ash::launcher::kPinnedAppsPrefAppIDPath, id);

- pinned_apps_list->Append(app_dict);

+ pinned_apps_list->Append(std::move(app_dict));

}

prefs->SetValue(pref_path(), std::move(pinned_apps_list));