Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chromeos/dbus/shill_manager_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chromeos/dbus/shill_manager_client.h"
+
+#include <memory>
+#include <utility>
+
 #include "base/bind.h"
+#include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/values.h"
 #include "chromeos/dbus/shill_client_unittest_base.h"
-#include "chromeos/dbus/shill_manager_client.h"
 #include "dbus/message.h"
 #include "dbus/object_path.h"
 #include "dbus/values_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 using testing::_;
 using testing::ByRef;
 
 namespace chromeos {
@@ skipping 134 matching lines @@
   wap_list_writer.CloseContainer(&property_dict_writer);
   variant_writer.CloseContainer(&wap_list_writer);
   type_entry_writer.CloseContainer(&wap_list_writer);
   type_dict_writer.CloseContainer(&type_entry_writer);
   writer.CloseContainer(&type_dict_writer);
 
 
   // Create the expected value.
   base::DictionaryValue type_dict_value;
   base::ListValue* type_entry_value = new base::ListValue;
-  base::DictionaryValue* property_dict_value = new base::DictionaryValue;
+  auto property_dict_value = base::MakeUnique<base::DictionaryValue>();
   property_dict_value->SetWithoutPathExpansion(
       shill::kGeoMacAddressProperty,
       new base::StringValue("01:23:45:67:89:AB"));
-  type_entry_value->Append(property_dict_value);
+  type_entry_value->Append(std::move(property_dict_value));
   type_dict_value.SetWithoutPathExpansion("wifi", type_entry_value);
 
   // Set expectations.
   PrepareForMethodCall(shill::kGetNetworksForGeolocation,
                        base::Bind(&ExpectNoArgument),
                        response.get());
   // Call method.
   client_->GetNetworksForGeolocation(base::Bind(&ExpectDictionaryValueResult,
                                                 &type_dict_value));
 
@@ skipping 257 matching lines @@
       arguments[7],
       base::Bind(&ExpectStringResultWithoutStatus, expected),
       mock_error_callback.GetCallback());
   EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
 
   // Run the message loop.
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace chromeos