Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/browser/chromeos/settings/cros_settings_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings_unittest.cc b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
index 1548cb89344b46bf8ab9670b9ca28efff19d5fa7..7fdf021d40ed2e92a5f1166cf32d7f09e704761d 100644
--- a/chrome/browser/chromeos/settings/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
@@ -122,7 +122,7 @@ TEST_F(CrosSettingsTest, SetWhitelist) {
// Setting the whitelist should also switch the value of
// kAccountsPrefAllowNewUser to false.
base::ListValue whitelist;
- whitelist.Append(new base::StringValue("me@owner"));
+ whitelist.AppendString("me@owner");
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
SetPref(kAccountsPrefUsers, &whitelist);
@@ -189,7 +189,7 @@ TEST_F(CrosSettingsTest, SetWhitelistAndNoNewUsers) {
// Setting the whitelist should allow us to set kAccountsPrefAllowNewUser to
// false (which is the implicit value too).
base::ListValue whitelist;
- whitelist.Append(new base::StringValue("me@owner"));
+ whitelist.AppendString("me@owner");
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
SetPref(kAccountsPrefUsers, &whitelist);
@@ -217,10 +217,10 @@ TEST_F(CrosSettingsTest, SetEphemeralUsersEnabled) {
TEST_F(CrosSettingsTest, FindEmailInList) {
base::ListValue list;
- list.Append(new base::StringValue("user@example.com"));
- list.Append(new base::StringValue("nodomain"));
- list.Append(new base::StringValue("with.dots@gmail.com"));
- list.Append(new base::StringValue("Upper@example.com"));
+ list.AppendString("user@example.com");
+ list.AppendString("nodomain");
+ list.AppendString("with.dots@gmail.com");
+ list.AppendString("Upper@example.com");
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
@@ -248,8 +248,8 @@ TEST_F(CrosSettingsTest, FindEmailInList) {
TEST_F(CrosSettingsTest, FindEmailInListWildcard) {
base::ListValue list;
- list.Append(new base::StringValue("user@example.com"));
- list.Append(new base::StringValue("*@example.com"));
+ list.AppendString("user@example.com");
+ list.AppendString("*@example.com");
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
« no previous file with comments | « chrome/browser/chromeos/proxy_cros_settings_parser.cc ('k') | chrome/browser/chromeos/settings/device_settings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698