chromeos/network/shill_property_handler_unittest.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/shill_property_handler_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/shill_property_handler_unittest.cc

diff --git a/chromeos/network/shill_property_handler_unittest.cc b/chromeos/network/shill_property_handler_unittest.cc

index 15434766b671ad9a72213ff2a17d13170fadc4f8..e5cc6ffdfe857827aff01d3e1137fe2b9aa44050 100644

--- a/chromeos/network/shill_property_handler_unittest.cc

+++ b/chromeos/network/shill_property_handler_unittest.cc

@@ -427,8 +427,8 @@ TEST_F(ShillPropertyHandlerTest, ShillPropertyHandlerIPConfigPropertyChanged) {

shill::kAddressProperty, ip_address,

base::Bind(&DoNothingWithCallStatus));

base::ListValue dns_servers;

- dns_servers.Append(new base::StringValue("192.168.1.100"));

- dns_servers.Append(new base::StringValue("192.168.1.101"));

+ dns_servers.AppendString("192.168.1.100");

+ dns_servers.AppendString("192.168.1.101");

DBusThreadManager::Get()->GetShillIPConfigClient()->SetProperty(

dbus::ObjectPath(kTestIPConfigPath),

shill::kNameServersProperty, dns_servers,