Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc b/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
index e6cfc39ecd33790615168e3cafccc6ecbd4a900a..de5e9d596adbd3bb4c33d92d25ce347ef2f255b1 100644
--- a/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
@@ -233,8 +233,8 @@ TEST_F(ArcPolicyBridgeTest, ExternalStorageDisabledTest) {
TEST_F(ArcPolicyBridgeTest, URLBlacklistTest) {
base::ListValue blacklist;
- blacklist.Append(new base::StringValue("www.blacklist1.com"));
- blacklist.Append(new base::StringValue("www.blacklist2.com"));
+ blacklist.AppendString("www.blacklist1.com");
+ blacklist.AppendString("www.blacklist2.com");
policy_map().Set(policy::key::kURLBlacklist, policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
blacklist.CreateDeepCopy(), nullptr);
@@ -248,8 +248,8 @@ TEST_F(ArcPolicyBridgeTest, URLBlacklistTest) {
TEST_F(ArcPolicyBridgeTest, URLWhitelistTest) {
base::ListValue whitelist;
- whitelist.Append(new base::StringValue("www.whitelist1.com"));
- whitelist.Append(new base::StringValue("www.whitelist2.com"));
+ whitelist.AppendString("www.whitelist1.com");
+ whitelist.AppendString("www.whitelist2.com");
policy_map().Set(policy::key::kURLWhitelist, policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
whitelist.CreateDeepCopy(), nullptr);
« no previous file with comments | « ash/common/system/chromeos/network/tray_sms.cc ('k') | chrome/browser/chromeos/extensions/dictionary_event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698