Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7041)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
index 96091bc2bfab4ecb40f36267f6191533570e90b2..7ca997bc0aeb14e3f8c1c768a074905ffc61152b 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
@@ -4,9 +4,12 @@
#include "chrome/browser/ui/webui/chromeos/login/network_dropdown.h"
+#include <memory>
#include <string>
+#include <utility>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
@@ -87,7 +90,7 @@ base::ListValue* NetworkMenuWebUI::ConvertMenuModel(ui::MenuModel* model) {
id = -2;
else
id = model->GetCommandIdAt(i);
- base::DictionaryValue* item = new base::DictionaryValue();
+ auto item = base::MakeUnique<base::DictionaryValue>();
item->SetInteger("id", id);
base::string16 label = model->GetLabelAt(i);
base::ReplaceSubstringsAfterOffset(&label, 0, base::ASCIIToUTF16("&&"),
@@ -108,7 +111,7 @@ base::ListValue* NetworkMenuWebUI::ConvertMenuModel(ui::MenuModel* model) {
}
if (type == ui::MenuModel::TYPE_SUBMENU)
item->Set("sub", ConvertMenuModel(model->GetSubmenuModelAt(i)));
- list->Append(item);
+ list->Append(std::move(item));
}
return list;
}

Powered by Google App Engine
This is Rietveld 408576698