Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc
diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
index 2015b7e32c3fc21d7ceb83e5fd9dab6d40c6a0ca..3e7db7188c3a08b82857a2c11c761b8ec12de629 100644
--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
@@ -69,10 +69,10 @@ void NotifyProcessOutput(content::BrowserContext* browser_context,
}
std::unique_ptr<base::ListValue> args(new base::ListValue());
- args->Append(new base::FundamentalValue(tab_id));
- args->Append(new base::FundamentalValue(terminal_id));
- args->Append(new base::StringValue(output_type));
- args->Append(new base::StringValue(output));
+ args->AppendInteger(tab_id);
+ args->AppendInteger(terminal_id);
+ args->AppendString(output_type);
+ args->AppendString(output);
extensions::EventRouter* event_router =
extensions::EventRouter::Get(browser_context);

Powered by Google App Engine
This is Rietveld 408576698