chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

index 3450f86b9653169bbde4c5e1b582779d61d4538e..384f67a5452d94083dbe05785e0d40dfe5dc07f8 100644

--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

@@ -713,8 +713,7 @@ void ChromeUserManagerImpl::RetrieveTrustedDevicePolicies() {

changed = true;

} else {

if ((*it)->GetType() != user_manager::USER_TYPE_PUBLIC_ACCOUNT)

- prefs_users_update->Append(

- new base::StringValue(account_id.GetUserEmail()));

+ prefs_users_update->AppendString(account_id.GetUserEmail());

++it;

}