Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2877)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index f0afec22e305a8dd4873cbe498128caf7209aae8..0dd17c13fdd3e73797ef3105080919272537da98 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -763,12 +763,12 @@ void FileManagerPrivateSearchDriveFunction::OnEntryDefinitionList(
for (EntryDefinitionList::const_iterator it = entry_definition_list->begin();
it != entry_definition_list->end();
++it) {
- base::DictionaryValue* entry = new base::DictionaryValue();
+ auto entry = base::MakeUnique<base::DictionaryValue>();
entry->SetString("fileSystemName", it->file_system_name);
entry->SetString("fileSystemRoot", it->file_system_root_url);
entry->SetString("fileFullPath", "/" + it->full_path.AsUTF8Unsafe());
entry->SetBoolean("fileIsDirectory", it->is_directory);
- entries->Append(entry);
+ entries->Append(std::move(entry));
}
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
@@ -863,7 +863,7 @@ void FileManagerPrivateSearchDriveMetadataFunction::OnEntryDefinitionList(
// file_manager_private_custom_bindings.js for how this is magically
// converted to a FileEntry.
for (size_t i = 0; i < entry_definition_list->size(); ++i) {
- base::DictionaryValue* result_dict = new base::DictionaryValue();
+ auto result_dict = base::MakeUnique<base::DictionaryValue>();
// FileEntry fields.
base::DictionaryValue* entry = new base::DictionaryValue();
@@ -881,7 +881,7 @@ void FileManagerPrivateSearchDriveMetadataFunction::OnEntryDefinitionList(
result_dict->SetString(
"highlightedBaseName",
search_result_info_list->at(i).highlighted_base_name);
- results_list->Append(result_dict);
+ results_list->Append(std::move(result_dict));
}
SetResult(std::move(results_list));
« no previous file with comments | « chrome/browser/chromeos/extensions/dictionary_event_router.cc ('k') | chrome/browser/chromeos/extensions/input_method_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698