Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h"
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/signin/easy_unlock_service.h"
@@ skipping 180 matching lines @@
   EXPECT_FALSE(handler.get());
 }
 
 TEST_F(EasyUnlockSettingsHandlerTest, EnabledStatus) {
   std::unique_ptr<EasyUnlockSettingsHandler> handler;
   handler.reset(new TestEasyUnlockSettingsHandler(profile()));
   handler->set_web_ui(web_ui());
 
   // Test the JS -> C++ -> JS callback path.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue("test-callback-id"));
+  list_args.AppendString("test-callback-id");
   handler->HandleGetEnabledStatus(&list_args);
 
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   const content::TestWebUI::CallData& data = *web_ui()->call_data().back();
   EXPECT_EQ("cr.webUIResponse", data.function_name());
 
   std::string callback_id;
   ASSERT_TRUE(data.arg1()->GetAsString(&callback_id));
   EXPECT_EQ("test-callback-id", callback_id);
@@ skipping 11 matching lines @@
   VerifyEnabledStatusCallback(3U, true);
 }
 
 TEST_F(EasyUnlockSettingsHandlerTest, TurnOffFlowStatus) {
   std::unique_ptr<EasyUnlockSettingsHandler> handler;
   handler.reset(new TestEasyUnlockSettingsHandler(profile()));
   handler->set_web_ui(web_ui());
 
   // Send an initial status query to turn on service observer.
   base::ListValue list_args1;
-  list_args1.Append(new base::StringValue("test-callback-id-1"));
+  list_args1.AppendString("test-callback-id-1");
   handler->HandleGetEnabledStatus(&list_args1);
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   base::ListValue list_args2;
-  list_args2.Append(new base::StringValue("test-callback-id-2"));
+  list_args2.AppendString("test-callback-id-2");
   handler->HandleGetTurnOffFlowStatus(&list_args2);
   VerifyTurnOffFlowStatusWebUIResponse(2U, "test-callback-id-2", "idle");
 
   handler->HandleStartTurnOffFlow(nullptr);
   VerifyTurnOffFlowStatusWebUIListenerCallback(3U, "pending");
 
   base::ListValue list_args3;
-  list_args3.Append(new base::StringValue("test-callback-id-3"));
+  list_args3.AppendString("test-callback-id-3");
   handler->HandleGetTurnOffFlowStatus(&list_args3);
   VerifyTurnOffFlowStatusWebUIResponse(4U, "test-callback-id-3", "pending");
 
   handler->HandleCancelTurnOffFlow(nullptr);
   VerifyTurnOffFlowStatusWebUIListenerCallback(5U, "idle");
 
   fake_easy_unlock_service()->SetTurnOffFlowFailForTest();
   VerifyTurnOffFlowStatusWebUIListenerCallback(6U, "server-error");
 
   base::ListValue list_args4;
-  list_args4.Append(new base::StringValue("test-callback-id-4"));
+  list_args4.AppendString("test-callback-id-4");
   handler->HandleGetTurnOffFlowStatus(&list_args4);
   VerifyTurnOffFlowStatusWebUIResponse(7U, "test-callback-id-4",
                                        "server-error");
 }
 
 }  // namespace settings
 }  // namespace chromeos