chrome/browser/chromeos/settings/device_settings_provider_unittest.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/device_settings_provider.cc ('k') | chrome/browser/chromeos/settings/owner_flags_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

index 844b1df490ac968a7fe34e1a999c728cf76a84df..528df8918fac0bd1e2a57cb1f72edde3ebf41655 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

+++ b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/settings/device_settings_provider.h"

#include <string>

+#include <utility>

#include "base/bind.h"

#include "base/callback.h"

@@ -404,7 +405,7 @@ TEST_F(DeviceSettingsProviderTest, LegacyDeviceLocalAccounts) {

policy::PolicyBuilder::kFakeUsername);

entry_dict->SetInteger(kAccountsPrefDeviceLocalAccountsKeyType,

policy::DeviceLocalAccount::TYPE_PUBLIC_SESSION);

- expected_accounts.Append(entry_dict.release());

+ expected_accounts.Append(std::move(entry_dict));

const base::Value* actual_accounts =

provider_->Get(kAccountsPrefDeviceLocalAccounts);

EXPECT_TRUE(base::Value::Equals(&expected_accounts, actual_accounts));