chrome/browser/chromeos/extensions/input_method_event_router.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/input_method_event_router.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/input_method_event_router.cc

diff --git a/chrome/browser/chromeos/extensions/input_method_event_router.cc b/chrome/browser/chromeos/extensions/input_method_event_router.cc

index c2728a2d685e843a6fdaaf8b39304d97ce506c2d..3581f254a45308df3a9e01fe06b76e397e201eef 100644

--- a/chrome/browser/chromeos/extensions/input_method_event_router.cc

+++ b/chrome/browser/chromeos/extensions/input_method_event_router.cc

@@ -43,8 +43,8 @@ void ExtensionInputMethodEventRouter::InputMethodChanged(

return;

std::unique_ptr<base::ListValue> args(new base::ListValue());

- args->Append(new base::StringValue(

- manager->GetActiveIMEState()->GetCurrentInputMethod().id()));

+ args->AppendString(

+ manager->GetActiveIMEState()->GetCurrentInputMethod().id());

// The router will only send the event to extensions that are listening.

std::unique_ptr<extensions::Event> event(