chrome/browser/extensions/api/autotest_private/autotest_private_api.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system/timezone_util.cc ('k') | chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

index 27e1777497183e29a26f9a43a31fc367169001da..d8aee6b8404a827a8b01f89c8a3a32d2d227db7e 100644

--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

@@ -8,6 +8,7 @@

#include <utility>

#include "base/lazy_instance.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string_number_conversions.h"

#include "build/build_config.h"

#include "chrome/browser/extensions/extension_action_manager.h"

@@ -363,14 +364,14 @@ AutotestPrivateGetVisibleNotificationsFunction::Run() {

#if defined(OS_CHROMEOS)

for (auto* notification :

message_center::MessageCenter::Get()->GetVisibleNotifications()) {

- base::DictionaryValue* result(new base::DictionaryValue);

+ auto result = base::MakeUnique<base::DictionaryValue>();

result->SetString("id", notification->id());

result->SetString("type", ConvertToString(notification->type()));

result->SetString("title", notification->title());

result->SetString("message", notification->message());

result->SetInteger("priority", notification->priority());

result->SetInteger("progress", notification->progress());

- values->Append(result);

+ values->Append(std::move(result));

}

#endif