Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/keyboard_handler.h"
 
 #include <stddef.h>
 
+#include <memory>
+#include <utility>
+
 #include "ash/common/new_window_delegate.h"
 #include "ash/common/wm_shell.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/chromeos_switches.h"
 #include "content/public/browser/web_ui.h"
 #include "ui/base/ime/chromeos/ime_keyboard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/events/devices/input_device_manager.h"
 
 namespace {
 const struct ModifierKeysSelectItem {
@@ skipping 108 matching lines @@
   localized_strings->SetString("showKeyboardShortcuts",
       l10n_util::GetStringUTF16(
           IDS_OPTIONS_SETTINGS_SHOW_KEYBOARD_SHORTCUTS));
 
   for (size_t i = 0; i < arraysize(kDataValuesNames); ++i) {
     base::ListValue* list_value = new base::ListValue();
     for (size_t j = 0; j < arraysize(kModifierKeysSelectItems); ++j) {
       const input_method::ModifierKey value =
           kModifierKeysSelectItems[j].value;
       const int message_id = kModifierKeysSelectItems[j].message_id;
-      base::ListValue* option = new base::ListValue();
-      option->Append(new base::FundamentalValue(value));
-      option->Append(new base::StringValue(l10n_util::GetStringUTF16(
-          message_id)));
-      list_value->Append(option);
+      auto option = base::MakeUnique<base::ListValue>();
+      option->AppendInteger(value);
+      option->AppendString(l10n_util::GetStringUTF16(message_id));
+      list_value->Append(std::move(option));
     }
     localized_strings->Set(kDataValuesNames[i], list_value);
   }
 }
 
 void KeyboardHandler::InitializePage() {
   bool has_diamond_key = base::CommandLine::ForCurrentProcess()->HasSwitch(
       chromeos::switches::kHasChromeOSDiamondKey);
   const base::FundamentalValue show_diamond_key_options(has_diamond_key);
 
@@ skipping 21 matching lines @@
 }
 
 void KeyboardHandler::UpdateCapsLockOptions() const {
   const base::FundamentalValue show_caps_lock_options(HasExternalKeyboard());
   web_ui()->CallJavascriptFunctionUnsafe(
       "options.KeyboardOverlay.showCapsLockOptions", show_caps_lock_options);
 }
 
 }  // namespace options
 }  // namespace chromeos