Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chromeos/dbus/shill_profile_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/values.h"
 #include "chromeos/dbus/shill_client_unittest_base.h"
 #include "chromeos/dbus/shill_profile_client.h"
 #include "dbus/message.h"
@@ skipping 47 matching lines @@
   // Create a signal.
   dbus::Signal signal(shill::kFlimflamProfileInterface,
                       shill::kMonitorPropertyChanged);
   dbus::MessageWriter writer(&signal);
   writer.AppendString(shill::kEntriesProperty);
   AppendVariantOfArrayOfStrings(&writer,
                                 std::vector<std::string>(1, kExampleEntryPath));
 
   // Set expectations.
   base::ListValue value;
-  value.Append(new base::StringValue(kExampleEntryPath));
+  value.AppendString(kExampleEntryPath);
   MockPropertyChangeObserver observer;
   EXPECT_CALL(observer,
               OnPropertyChanged(
                   shill::kEntriesProperty,
                   ValueEq(value))).Times(1);
 
   // Add the observer
   client_->AddPropertyChangedObserver(
       dbus::ObjectPath(kDefaultProfilePath),
       &observer);
@@ skipping 21 matching lines @@
   dbus::MessageWriter entry_writer(NULL);
   array_writer.OpenDictEntry(&entry_writer);
   entry_writer.AppendString(shill::kEntriesProperty);
   AppendVariantOfArrayOfStrings(&entry_writer,
                                 std::vector<std::string>(1, kExampleEntryPath));
   array_writer.CloseContainer(&entry_writer);
   writer.CloseContainer(&array_writer);
 
   // Create the expected value.
   base::ListValue* entries = new base::ListValue;
-  entries->Append(new base::StringValue(kExampleEntryPath));
+  entries->AppendString(kExampleEntryPath);
   base::DictionaryValue value;
   value.SetWithoutPathExpansion(shill::kEntriesProperty, entries);
   // Set expectations.
   PrepareForMethodCall(shill::kGetPropertiesFunction,
                        base::Bind(&ExpectNoArgument),
                        response.get());
   // Call method.
   MockErrorCallback error_callback;
   client_->GetProperties(dbus::ObjectPath(kDefaultProfilePath),
                          base::Bind(&ExpectDictionaryValueResultWithoutStatus,
@@ skipping 58 matching lines @@
                        mock_closure.GetCallback(),
                        mock_error_callback.GetCallback());
   EXPECT_CALL(mock_closure, Run()).Times(1);
   EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
 
   // Run the message loop.
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace chromeos