chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

index aaf68c6bfcb4fa3888b1ca7c43b8c38784b31e9f..fe4603665fd240a1ff42ff6320fbb02a6b118e45 100644

--- a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

@@ -124,7 +124,7 @@ void EnterprisePlatformKeysGetCertificatesFunction::OnGotCertificates(

}

std::unique_ptr<base::ListValue> results(new base::ListValue());

- results->Append(client_certs.release());

+ results->Append(std::move(client_certs));

Respond(ArgumentList(std::move(results)));

}