Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/chromeos/settings/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include <memory.h>
 #include <stddef.h>
 #include <utility>
 
@@ skipping 154 matching lines @@
       policy.has_ephemeral_users_enabled() &&
       policy.ephemeral_users_enabled().has_ephemeral_users_enabled() &&
       policy.ephemeral_users_enabled().ephemeral_users_enabled());
 
   std::unique_ptr<base::ListValue> list(new base::ListValue());
   const em::UserWhitelistProto& whitelist_proto = policy.user_whitelist();
   const RepeatedPtrField<std::string>& whitelist =
       whitelist_proto.user_whitelist();
   for (RepeatedPtrField<std::string>::const_iterator it = whitelist.begin();
        it != whitelist.end(); ++it) {
-    list->Append(new base::StringValue(*it));
+    list->AppendString(*it);
   }
   new_values_cache->SetValue(kAccountsPrefUsers, std::move(list));
 
   std::unique_ptr<base::ListValue> account_list(new base::ListValue());
   const em::DeviceLocalAccountsProto device_local_accounts_proto =
       policy.device_local_accounts();
   const RepeatedPtrField<em::DeviceLocalAccountInfoProto>& accounts =
       device_local_accounts_proto.account();
   RepeatedPtrField<em::DeviceLocalAccountInfoProto>::const_iterator entry;
   for (entry = accounts.begin(); entry != accounts.end(); ++entry) {
@@ skipping 49 matching lines @@
   new_values_cache->SetBoolean(
       kAccountsPrefDeviceLocalAccountPromptForNetworkWhenOffline,
       policy.device_local_accounts().prompt_for_network_when_offline());
 
   if (policy.has_start_up_flags()) {
     std::unique_ptr<base::ListValue> list(new base::ListValue());
     const em::StartUpFlagsProto& flags_proto = policy.start_up_flags();
     const RepeatedPtrField<std::string>& flags = flags_proto.flags();
     for (RepeatedPtrField<std::string>::const_iterator it = flags.begin();
          it != flags.end(); ++it) {
-      list->Append(new base::StringValue(*it));
+      list->AppendString(*it);
     }
     new_values_cache->SetValue(kStartUpFlags, std::move(list));
   }
 
   if (policy.has_saml_settings()) {
     new_values_cache->SetBoolean(
         kAccountsPrefTransferSAMLCookies,
         policy.saml_settings().transfer_saml_cookies());
   }
 
@@ skipping 18 matching lines @@
         kLoginAuthenticationBehavior,
         policy.login_authentication_behavior().login_authentication_behavior());
   }
 
   if (policy.has_login_video_capture_allowed_urls()) {
     std::unique_ptr<base::ListValue> list(new base::ListValue());
     const em::LoginVideoCaptureAllowedUrlsProto&
         login_video_capture_allowed_urls_proto =
             policy.login_video_capture_allowed_urls();
     for (const auto& value : login_video_capture_allowed_urls_proto.urls()) {
-      list->Append(new base::StringValue(value));
+      list->AppendString(value);
     }
     new_values_cache->SetValue(kLoginVideoCaptureAllowedUrls, std::move(list));
   }
 
   if (policy.has_login_apps()) {
     std::unique_ptr<base::ListValue> login_apps(new base::ListValue);
     const em::LoginAppsProto& login_apps_proto(policy.login_apps());
     for (const auto& login_app : login_apps_proto.login_apps())
-      login_apps->Append(new base::StringValue(login_app));
+      login_apps->AppendString(login_app);
     new_values_cache->SetValue(kLoginApps, std::move(login_apps));
   }
 }
 
 void DecodeNetworkPolicies(
     const em::ChromeDeviceSettingsProto& policy,
     PrefValueMap* new_values_cache) {
   // kSignedDataRoamingEnabled has a default value of false.
   new_values_cache->SetBoolean(
       kSignedDataRoamingEnabled,
@@ skipping 10 matching lines @@
         policy.auto_update_settings();
     if (au_settings_proto.has_update_disabled()) {
       new_values_cache->SetBoolean(kUpdateDisabled,
                                    au_settings_proto.update_disabled());
     }
     const RepeatedField<int>& allowed_connection_types =
         au_settings_proto.allowed_connection_types();
     std::unique_ptr<base::ListValue> list(new base::ListValue());
     for (RepeatedField<int>::const_iterator i(allowed_connection_types.begin());
          i != allowed_connection_types.end(); ++i) {
-      list->Append(new base::FundamentalValue(*i));
+      list->AppendInteger(*i);
     }
     new_values_cache->SetValue(kAllowedConnectionTypesForUpdate,
                                std::move(list));
   }
 }
 
 void DecodeReportingPolicies(
     const em::ChromeDeviceSettingsProto& policy,
     PrefValueMap* new_values_cache) {
   if (policy.has_device_reporting()) {
@@ skipping 505 matching lines @@
   // Notify the observers we are done.
   std::vector<base::Closure> callbacks;
   callbacks.swap(callbacks_);
   for (size_t i = 0; i < callbacks.size(); ++i)
     callbacks[i].Run();
 
   return settings_loaded;
 }
 
 }  // namespace chromeos