Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chromeos/network/network_util.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_handler_unittest.cc ('k') | chromeos/network/network_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_util.cc
diff --git a/chromeos/network/network_util.cc b/chromeos/network/network_util.cc
index a8c83d86372b234659522d70c63053c226a99148..8968d844ecd77f5265f14895a77c3c2cbfd06098 100644
--- a/chromeos/network/network_util.cc
+++ b/chromeos/network/network_util.cc
@@ -7,6 +7,8 @@
#include <stddef.h>
#include <stdint.h>
+#include <utility>
+
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_tokenizer.h"
#include "base/strings/string_util.h"
@@ -204,7 +206,7 @@ std::unique_ptr<base::ListValue> TranslateNetworkListToONC(
for (const NetworkState* state : network_states) {
std::unique_ptr<base::DictionaryValue> onc_dictionary =
TranslateNetworkStateToONC(state);
- network_properties_list->Append(onc_dictionary.release());
+ network_properties_list->Append(std::move(onc_dictionary));
}
return network_properties_list;
}
« no previous file with comments | « chromeos/network/network_state_handler_unittest.cc ('k') | chromeos/network/network_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698