Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5124)

Unified Diff: chrome/browser/chromeos/extensions/dictionary_event_router.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/dictionary_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/dictionary_event_router.cc b/chrome/browser/chromeos/extensions/dictionary_event_router.cc
index d16c12fcd9a29c9be76603861022dc8b2ba5e90f..7ee32c89eac1af67ce5103bb0901ea448a3e867b 100644
--- a/chrome/browser/chromeos/extensions/dictionary_event_router.cc
+++ b/chrome/browser/chromeos/extensions/dictionary_event_router.cc
@@ -80,8 +80,8 @@ void ExtensionDictionaryEventRouter::OnCustomDictionaryChanged(
removed_words->AppendString(word);
std::unique_ptr<base::ListValue> args(new base::ListValue());
- args->Append(added_words.release());
- args->Append(removed_words.release());
+ args->Append(std::move(added_words));
+ args->Append(std::move(removed_words));
// The router will only send the event to extensions that are listening.
std::unique_ptr<extensions::Event> event(new extensions::Event(

Powered by Google App Engine
This is Rietveld 408576698