Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
index 1f755210715bd8b1df3ca85be49f4fe10d4e206a..f6969d64ce540e17ab3a406c78d9118f5dce114d 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
@@ -358,7 +358,7 @@ bool GetProxyPrefValue(const UIProxyConfigService& config_service,
base::ListValue* list = new base::ListValue();
net::ProxyBypassRules::RuleList bypass_rules = config.bypass_rules.rules();
for (size_t x = 0; x < bypass_rules.size(); x++)
- list->Append(new base::StringValue(bypass_rules[x]->ToString()));
+ list->AppendString(bypass_rules[x]->ToString());
data = list;
} else {
*out_value = NULL;

Powered by Google App Engine
This is Rietveld 408576698