Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8395)

Unified Diff: chrome/browser/ui/webui/chromeos/power_ui.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/power_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/power_ui.cc b/chrome/browser/ui/webui/chromeos/power_ui.cc
index 32b6f0f08252ee657979032fb4e30a1fa4bdc062..eefd41906f4da6fc913b7a8eb5447c0ddd67e801 100644
--- a/chrome/browser/ui/webui/chromeos/power_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/power_ui.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <utility>
+
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/compiler_specific.h"
@@ -91,7 +93,7 @@ void PowerMessageHandler::OnGetBatteryChargeData(const base::ListValue* value) {
element->SetBoolean("externalPower", sample.external_power);
element->SetDouble("time", sample.time.ToJsTime());
- js_power_supply_data.Append(element.release());
+ js_power_supply_data.Append(std::move(element));
}
base::ListValue js_system_resumed_data;
@@ -150,7 +152,7 @@ void PowerMessageHandler::GetJsSystemResumedData(base::ListValue *data) {
sample.sleep_duration.InMillisecondsF());
element->SetDouble("time", sample.time.ToJsTime());
- data->Append(element.release());
+ data->Append(std::move(element));
}
}
@@ -176,9 +178,9 @@ void PowerMessageHandler::GetJsStateOccupancyData(
}
js_sample->Set("timeInState", state_dict.release());
- js_sample_list->Append(js_sample.release());
+ js_sample_list->Append(std::move(js_sample));
}
- js_data->Append(js_sample_list.release());
+ js_data->Append(std::move(js_sample_list));
}
}
« no previous file with comments | « chrome/browser/ui/webui/chromeos/network_ui.cc ('k') | chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698