Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4777)

Unified Diff: chrome/browser/chromeos/extensions/input_method_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/input_method_api.cc
diff --git a/chrome/browser/chromeos/extensions/input_method_api.cc b/chrome/browser/chromeos/extensions/input_method_api.cc
index 601df49d6f99e467ef48111bdfcf3a3a26e9fd38..d63b0d824555e05054c8197d917c90f815cfa4b6 100644
--- a/chrome/browser/chromeos/extensions/input_method_api.cc
+++ b/chrome/browser/chromeos/extensions/input_method_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/chromeos/extensions/input_method_api.h"
#include <stddef.h>
+#include <memory>
#include <set>
#include <string>
#include <utility>
@@ -142,11 +143,11 @@ InputMethodPrivateGetInputMethodsFunction::Run() {
for (size_t i = 0; i < input_methods->size(); ++i) {
const chromeos::input_method::InputMethodDescriptor& input_method =
(*input_methods)[i];
- base::DictionaryValue* val = new base::DictionaryValue();
+ auto val = base::MakeUnique<base::DictionaryValue>();
val->SetString("id", input_method.id());
val->SetString("name", util->GetInputMethodLongName(input_method));
val->SetString("indicator", util->GetInputMethodShortName(input_method));
- output->Append(val);
+ output->Append(std::move(val));
}
return RespondNow(OneArgument(std::move(output)));
#endif

Powered by Google App Engine
This is Rietveld 408576698