chrome/browser/chromeos/file_system_provider/operations/write_file.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/url_util.cc ('k') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

index 2ccbc2f4a49c00b2a92a9bbd7a05351c0e5a9a92..528ca4b927e25b8c031f079acb1b3ae7cc47fc08 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

@@ -54,7 +54,7 @@ bool WriteFile::Execute(int request_id) {

base::BinaryValue::CreateWithCopiedBuffer(buffer_->data(), length_));

std::unique_ptr<base::ListValue> event_args(new base::ListValue);

- event_args->Append(options_as_value.release());

+ event_args->Append(std::move(options_as_value));

return SendEvent(

request_id,