chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc ('k') | chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc b/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc

index 3a32b98a07492ca6e5c63e47b610595441c1307f..40346d4c15e938088b4802b47354283c15c418d2 100644

--- a/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include <string>

+#include <utility>

#include "base/message_loop/message_loop.h"

#include "base/values.h"

@@ -70,7 +71,7 @@ class ExistingUserControllerAutoLoginTest : public ::testing::Test {

kAccountsPrefDeviceLocalAccountsKeyType,

policy::DeviceLocalAccount::TYPE_PUBLIC_SESSION);

base::ListValue accounts;

- accounts.Append(account.release());

+ accounts.Append(std::move(account));

CrosSettings::Get()->Set(kAccountsPrefDeviceLocalAccounts, accounts);

// Prevent settings changes from auto-starting the timer.