Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/chromeos/file_manager/file_browser_handlers.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/file_browser_handlers.cc
diff --git a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
index 013aada63706e1731ebdc4dbf62d7e5248c9a6c8..4d4985c9ab0d36cd4fb6736a661bc99e08c412e3 100644
--- a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
+++ b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
@@ -387,7 +387,7 @@ void FileBrowserHandlerExecutor::SetupPermissionsAndDispatchEvent(
file_definition_list.get(), extension_.get(), handler_pid);
std::unique_ptr<base::ListValue> event_args(new base::ListValue());
- event_args->Append(new base::StringValue(action_id_));
+ event_args->AppendString(action_id_);
base::DictionaryValue* details = new base::DictionaryValue();
event_args->Append(details);
// Get file definitions. These will be replaced with Entry instances by
« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_api.cc ('k') | chrome/browser/chromeos/file_manager/url_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698