Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5931)

Unified Diff: chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc b/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
index 434c70f5523351ef347d981315b3a88d61425111..13aa64638240c9ee2d97b1c2412d68ae4110a91a 100644
--- a/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
+++ b/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <utility>
+
#include "base/at_exit.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
@@ -137,13 +139,13 @@ TEST_F(L10nUtilTest, FindMostRelevantLocale) {
base::ListValue available_locales;
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
dict->SetString("value", "de");
- available_locales.Append(dict.release());
+ available_locales.Append(std::move(dict));
dict.reset(new base::DictionaryValue);
dict->SetString("value", "fr");
- available_locales.Append(dict.release());
+ available_locales.Append(std::move(dict));
dict.reset(new base::DictionaryValue);
dict->SetString("value", "en-GB");
- available_locales.Append(dict.release());
+ available_locales.Append(std::move(dict));
std::vector<std::string> most_relevant_language_codes;
EXPECT_EQ("en-US", FindMostRelevantLocale(most_relevant_language_codes,
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/l10n_util.cc ('k') | chrome/browser/ui/webui/chromeos/login/network_dropdown.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698