Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_drive.h"
 
 #include <map>
 #include <memory>
 #include <set>
 #include <utility>
@@ skipping 745 matching lines @@
     const GURL& next_link,
     std::unique_ptr<SearchResultInfoList> search_result_info_list,
     std::unique_ptr<EntryDefinitionList> entry_definition_list) {
   DCHECK_EQ(search_result_info_list->size(), entry_definition_list->size());
   base::ListValue* entries = new base::ListValue();
 
   // Convert Drive files to something File API stack can understand.
   for (EntryDefinitionList::const_iterator it = entry_definition_list->begin();
        it != entry_definition_list->end();
        ++it) {
-    base::DictionaryValue* entry = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());

[sky, 2016/10/03 21:48:18]

MakeUnique

     entry->SetString("fileSystemName", it->file_system_name);
     entry->SetString("fileSystemRoot", it->file_system_root_url);
     entry->SetString("fileFullPath", "/" + it->full_path.AsUTF8Unsafe());
     entry->SetBoolean("fileIsDirectory", it->is_directory);
-    entries->Append(entry);
+    entries->Append(std::move(entry));
   }
 
   std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
   result->Set("entries", entries);
   result->SetString("nextFeed", next_link.spec());
 
   SetResult(std::move(result));
   SendResponse(true);
 }
 
@@ skipping 74 matching lines @@
     std::unique_ptr<drive::MetadataSearchResultVector> search_result_info_list,
     std::unique_ptr<EntryDefinitionList> entry_definition_list) {
   DCHECK_EQ(search_result_info_list->size(), entry_definition_list->size());
   std::unique_ptr<base::ListValue> results_list(new base::ListValue());
 
   // Convert Drive files to something File API stack can understand.  See
   // file_browser_handler_custom_bindings.cc and
   // file_manager_private_custom_bindings.js for how this is magically
   // converted to a FileEntry.
   for (size_t i = 0; i < entry_definition_list->size(); ++i) {
-    base::DictionaryValue* result_dict = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> result_dict(

[sky, 2016/10/03 21:48:18]

MakeUnique (I'm not going to mention it anymore).

+        new base::DictionaryValue());
 
     // FileEntry fields.
     base::DictionaryValue* entry = new base::DictionaryValue();
     entry->SetString(
         "fileSystemName", entry_definition_list->at(i).file_system_name);
     entry->SetString(
         "fileSystemRoot", entry_definition_list->at(i).file_system_root_url);
     entry->SetString(
         "fileFullPath",
         "/" + entry_definition_list->at(i).full_path.AsUTF8Unsafe());
     entry->SetBoolean("fileIsDirectory",
                       entry_definition_list->at(i).is_directory);
 
     result_dict->Set("entry", entry);
     result_dict->SetString(
         "highlightedBaseName",
         search_result_info_list->at(i).highlighted_base_name);
-    results_list->Append(result_dict);
+    results_list->Append(std::move(result_dict));
   }
 
   SetResult(std::move(results_list));
   SendResponse(true);
 }
 
 ExtensionFunction::ResponseAction
 FileManagerPrivateGetDriveConnectionStateFunction::Run() {
   api::file_manager_private::DriveConnectionState result;
 
@@ skipping 249 matching lines @@
   }
 
   const std::string url =
       download_url_.Resolve("?alt=media&access_token=" + access_token).spec();
   SetResult(base::MakeUnique<base::StringValue>(url));
 
   SendResponse(true);
 }
 
 }  // namespace extensions