Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
index d10c4f3982c1cb07944b0b8ea7d032d4ecaa1af4..0fefc22f34b9547d1019bfef504c86a1f880732b 100644
--- a/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
+++ b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
@@ -161,7 +161,7 @@ void DecodeLoginPolicies(const em::ChromeDeviceSettingsProto& policy,
const em::UserWhitelistProto& container(policy.user_whitelist());
std::unique_ptr<base::ListValue> whitelist(new base::ListValue);
for (const auto& entry : container.user_whitelist())
- whitelist->Append(new base::StringValue(entry));
+ whitelist->AppendString(entry);
policies->Set(key::kDeviceUserWhitelist, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_MACHINE, POLICY_SOURCE_CLOUD,
std::move(whitelist), nullptr);
@@ -302,7 +302,7 @@ void DecodeLoginPolicies(const em::ChromeDeviceSettingsProto& policy,
policy.login_video_capture_allowed_urls());
std::unique_ptr<base::ListValue> urls(new base::ListValue());
for (const auto& entry : container.urls()) {
- urls->Append(new base::StringValue(entry));
+ urls->AppendString(entry);
}
policies->Set(key::kLoginVideoCaptureAllowedUrls, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_MACHINE, POLICY_SOURCE_CLOUD, std::move(urls),
@@ -313,7 +313,7 @@ void DecodeLoginPolicies(const em::ChromeDeviceSettingsProto& policy,
const em::LoginAppsProto& login_apps_proto(policy.login_apps());
std::unique_ptr<base::ListValue> login_apps(new base::ListValue);
for (const auto& login_app : login_apps_proto.login_apps())
- login_apps->Append(new base::StringValue(login_app));
+ login_apps->AppendString(login_app);
policies->Set(key::kLoginApps, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
POLICY_SOURCE_CLOUD, std::move(login_apps), nullptr);
}
« no previous file with comments | « chrome/browser/chromeos/policy/device_local_account.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698