Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438003003: Move all ShaderBuilder files to GLSL (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@glslProgBuild
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move all ShaderBuilder files to GLSL BUG=skia: Committed: https://skia.googlesource.com/skia/+/2d721d33aad192cc8a7a1321504b39bdca2a57ce

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -1550 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
M gm/dcshader.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkLightingShader.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 3 chunks +11 lines, -12 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 5 chunks +24 lines, -23 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 13 chunks +22 lines, -21 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 16 chunks +29 lines, -28 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 7 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 13 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 5 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 8 chunks +15 lines, -13 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 6 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 7 chunks +26 lines, -23 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 6 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSLBlend.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSLBlend.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
D src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +0 lines, -201 lines 0 comments Download
D src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +0 lines, -268 lines 0 comments Download
D src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 chunk +0 lines, -32 lines 0 comments Download
D src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 3 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D src/gpu/gl/builders/GrGLShaderBuilder.h View 1 chunk +0 lines, -200 lines 0 comments Download
D src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 chunk +0 lines, -209 lines 0 comments Download
D src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
A + src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 8 chunks +14 lines, -14 lines 0 comments Download
A + src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 13 chunks +21 lines, -21 lines 0 comments Download
A + src/gpu/glsl/GrGLSLGeometryShaderBuilder.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + src/gpu/glsl/GrGLSLGeometryShaderBuilder.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 8 chunks +23 lines, -20 lines 0 comments Download
A + src/gpu/glsl/GrGLSLShaderBuilder.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + src/gpu/glsl/GrGLSLShaderBuilder.cpp View 6 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/glsl/GrGLSLTextureSampler.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/glsl/GrGLSLVertexShaderBuilder.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + src/gpu/glsl/GrGLSLVertexShaderBuilder.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1416423003 Patch 20001

Messages

Total messages: 12 (5 generated)
egdaniel
This should just be a massive name change cl
5 years, 1 month ago (2015-11-11 20:44:39 UTC) #2
joshualitt
On 2015/11/11 20:44:39, egdaniel wrote: > This should just be a massive name change cl ...
5 years, 1 month ago (2015-11-11 20:49:09 UTC) #3
joshualitt
https://codereview.chromium.org/1438003003/diff/1/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/1438003003/diff/1/src/gpu/effects/GrRRectEffect.cpp#newcode526 src/gpu/effects/GrRRectEffect.cpp:526: fInvRadiiSqdUniform = args.fBuilder->addUniform(GrGLSLProgramBuilder::kFragment_Visibility, \n https://codereview.chromium.org/1438003003/diff/1/src/gpu/effects/GrRRectEffect.cpp#newcode537 src/gpu/effects/GrRRectEffect.cpp:537: fInvRadiiSqdUniform = args.fBuilder->addUniform(GrGLSLProgramBuilder::kFragment_Visibility, ...
5 years, 1 month ago (2015-11-11 20:49:18 UTC) #4
egdaniel
https://codereview.chromium.org/1438003003/diff/1/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/1438003003/diff/1/src/gpu/effects/GrRRectEffect.cpp#newcode526 src/gpu/effects/GrRRectEffect.cpp:526: fInvRadiiSqdUniform = args.fBuilder->addUniform(GrGLSLProgramBuilder::kFragment_Visibility, On 2015/11/11 20:49:18, joshualitt wrote: > ...
5 years, 1 month ago (2015-11-11 20:52:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438003003/20001
5 years, 1 month ago (2015-11-11 20:53:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438003003/20001
5 years, 1 month ago (2015-11-11 20:53:34 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 21:06:09 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2d721d33aad192cc8a7a1321504b39bdca2a57ce

Powered by Google App Engine
This is Rietveld 408576698