Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1416423003: Make GrGLSLProgramBuilder base class for ProgramBuilder (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, ethannicholas
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrGLSLProgramBuilder base class for GrGLProgramBuilder. This CL still keeps the weird diamond shape we have for all our ProgramBuilders. However, the GrGLSL base class will allow us to pull multiple other parts of our program setup away from GL which will eventually allow us to break up the diamond. As part of this all ShaderBuilder subclass have been made gl independent, however I will move them to GLSL files/class names in a follow on CL. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8dcdedc4a087ea46ce1e2458d335d60918e56310

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -492 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 15 chunks +18 lines, -18 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +26 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 4 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 4 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 7 chunks +18 lines, -10 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 8 chunks +18 lines, -36 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 10 chunks +13 lines, -249 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 11 chunks +22 lines, -35 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 2 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 4 chunks +5 lines, -19 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 3 chunks +26 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +8 lines, -1 line 0 comments Download
A src/gpu/glsl/GrGLSLProgramBuilder.h View 1 1 chunk +261 lines, -0 lines 0 comments Download
A src/gpu/glsl/GrGLSLProgramBuilder.cpp View 1 chunk +39 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
egdaniel
5 years, 1 month ago (2015-11-10 20:48:33 UTC) #4
bsalomon
lgtm https://codereview.chromium.org/1416423003/diff/1/src/gpu/glsl/GrGLSLProgramBuilder.h File src/gpu/glsl/GrGLSLProgramBuilder.h (right): https://codereview.chromium.org/1416423003/diff/1/src/gpu/glsl/GrGLSLProgramBuilder.h#newcode37 src/gpu/glsl/GrGLSLProgramBuilder.h:37: supported at this time. The actual uniform name ...
5 years, 1 month ago (2015-11-10 21:23:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416423003/20001
5 years, 1 month ago (2015-11-11 14:15:59 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 14:27:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8dcdedc4a087ea46ce1e2458d335d60918e56310

Powered by Google App Engine
This is Rietveld 408576698