Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 1418453013: Change terms URL to chrome://credits. (Closed)

Created:
5 years, 1 month ago by bungeman-chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change terms URL to chrome://credits. The existing terms seen at chrome://terms have a link to http://code.google.com/chromium/terms.html and various translations of it. This link target no longer exists as it was deleted due to never being updated. As a result, replace it with a link to chrome://credits, which is at least up to date and exists. BUG=chromium:91111 Committed: https://crrev.com/c91b3c1cad85c7fcfa8caf5892de80cea904cd2a Cr-Commit-Position: refs/heads/master@{#359034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -52 lines) Patch
M chrome/app/resources/terms/terms_am.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_bg.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_bn.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ca.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_cs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_da.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_de.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/terms/terms_el.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_en.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_en-GB.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_es.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_es-419.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_et.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_fa.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_fi.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_fil.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_fr.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_gu.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_he.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_hi.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_hr.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_hu.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_id.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_it.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ja.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_kn.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ko.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_lt.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_lv.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ml.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_mr.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_nb.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_nl.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_pl.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_pt-BR.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_pt-PT.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ro.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ru.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_sk.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_sl.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_sr.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_sv.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_ta.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_te.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_th.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_tr.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_uk.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_vi.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_zh-CN.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/terms/terms_zh-TW.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418453013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418453013/1
5 years, 1 month ago (2015-11-10 16:09:37 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 16:22:04 UTC) #4
bungeman-chromium
This updates all of the terms_* except terms_sw.html which doesn't have any link in the ...
5 years, 1 month ago (2015-11-10 16:26:22 UTC) #6
bungeman-chromium
5 years, 1 month ago (2015-11-10 21:55:32 UTC) #8
bungeman-chromium
laforge: it looks like you modified some of this some time in the distant past, ...
5 years, 1 month ago (2015-11-10 22:06:27 UTC) #10
cpu_(ooo_6.6-7.5)
lgtm
5 years, 1 month ago (2015-11-10 22:20:18 UTC) #11
laforge
On 2015/11/10 22:20:18, cpu wrote: > lgtm lgtm
5 years, 1 month ago (2015-11-10 22:46:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418453013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418453013/1
5 years, 1 month ago (2015-11-11 03:34:26 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 03:40:31 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 03:41:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c91b3c1cad85c7fcfa8caf5892de80cea904cd2a
Cr-Commit-Position: refs/heads/master@{#359034}

Powered by Google App Engine
This is Rietveld 408576698