Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434313002: Make all GrFragmentProcessors GL independent. (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make all GrFragmentProcessors GL independent. TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/64c4728c70001ed074fecf5c4e083781987b12e9

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -997 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M gm/dcshader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gyp/gpu.gypi View 1 4 chunks +6 lines, -4 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/effects/GrConstColorProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 5 chunks +5 lines, -6 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 7 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 4 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 4 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 3 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 4 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
D src/gpu/gl/GrGLFragmentProcessor.h View 1 chunk +0 lines, -116 lines 0 comments Download
D src/gpu/gl/GrGLFragmentProcessor.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/GrGLSLBlend.h View 1 chunk +0 lines, -24 lines 0 comments Download
D src/gpu/gl/GrGLSLBlend.cpp View 1 chunk +0 lines, -435 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 1 chunk +0 lines, -45 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 3 chunks +7 lines, -2 lines 0 comments Download
A + src/gpu/glsl/GrGLSLBlend.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/glsl/GrGLSLBlend.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/glsl/GrGLSLFragmentProcessor.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
A src/gpu/glsl/GrGLSLUtil.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A src/gpu/glsl/GrGLSLUtil.cpp View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
egdaniel
5 years, 1 month ago (2015-11-12 20:00:39 UTC) #2
robertphillips
lgtm
5 years, 1 month ago (2015-11-12 20:13:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434313002/40001
5 years, 1 month ago (2015-11-13 14:21:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3869)
5 years, 1 month ago (2015-11-13 14:22:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434313002/40001
5 years, 1 month ago (2015-11-13 14:25:56 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 14:54:22 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/64c4728c70001ed074fecf5c4e083781987b12e9

Powered by Google App Engine
This is Rietveld 408576698