Make base::Base64Encode() return void

The comment in base64.h implies that base::Base64Encode() can return false, but
this cannot happen in practice. Fix the comment.

The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.

Remove unneeded integer cast.

Change the return type to void.

BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239759

[Adam Rice, 2013-12-05 03:09:32]

friendly ping

[brettw, 2013-12-05 06:33:56]

https://codereview.chromium.org/86913002/diff/1/base/base64.h
File base/base64.h (right):

https://codereview.chromium.org/86913002/diff/1/base/base64.h#newcode16
base/base64.h:16: BASE_EXPORT bool Base64Encode(const StringPiece& input,
std::string* output);
It seems like we should just fix the return value to void instead.

[Adam Rice, 2013-12-09 09:23:45]

Something like this?

[brettw, 2013-12-09 19:36:26]

LGTM with one style not.

You can TBR the owners of the downstream modules for this type of change.

https://codereview.chromium.org/86913002/diff/110001/google_apis/gaia/oauth_r...
File google_apis/gaia/oauth_request_signer.cc (right):

https://codereview.chromium.org/86913002/diff/110001/google_apis/gaia/oauth_r...
google_apis/gaia/oauth_request_signer.cc:208: if (result)
Use {} for this since it's >1 line.

[commit-bot: I haz the power, 2013-12-10 07:59:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/86913002/180001

[commit-bot: I haz the power, 2013-12-10 11:55:14]

Change committed as 239759