chrome/browser/devtools/adb/android_rsa.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/adb/android_rsa.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/adb/android_rsa.cc

diff --git a/chrome/browser/devtools/adb/android_rsa.cc b/chrome/browser/devtools/adb/android_rsa.cc

index 371c4330583f105eff5dc7cb695cf096cb21a4b8..27a52b45159ab7eed5886ff50486a546a868141d 100644

--- a/chrome/browser/devtools/adb/android_rsa.cc

+++ b/chrome/browser/devtools/adb/android_rsa.cc

@@ -196,10 +196,9 @@ crypto::RSAPrivateKey* AndroidRSAPrivateKey(Profile* profile) {

return NULL;

std::string key_string(key_info.begin(), key_info.end());

- if (base::Base64Encode(key_string, &encoded_key)) {

- profile->GetPrefs()->SetString(prefs::kDevToolsAdbKey,

- encoded_key);

- }

+ base::Base64Encode(key_string, &encoded_key);

+ profile->GetPrefs()->SetString(prefs::kDevToolsAdbKey,

+ encoded_key);

}

return key.release();

}