chrome/browser/metrics/metrics_log.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index 72d738b00100232bfe80d5d36fb16e0d31d12ada..9ebf3bc72e2dbe7c9e57ca7e3e8a4aade3a9e105 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -803,8 +803,8 @@ void MetricsLog::RecordEnvironment(

std::string serialied_system_profile;

std::string base64_system_profile;

- if (system_profile->SerializeToString(&serialied_system_profile) &&

- base::Base64Encode(serialied_system_profile, &base64_system_profile)) {

+ if (system_profile->SerializeToString(&serialied_system_profile)) {

+ base::Base64Encode(serialied_system_profile, &base64_system_profile);

PrefService* local_state = GetPrefService();

local_state->SetString(prefs::kStabilitySavedSystemProfile,

base64_system_profile);