chrome/browser/metrics/variations/variations_service_unittest.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service_unittest.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/variations/variations_service_unittest.cc

diff --git a/chrome/browser/metrics/variations/variations_service_unittest.cc b/chrome/browser/metrics/variations/variations_service_unittest.cc

index bda76ac3a33488ecfef044923a4ab2f55ad9e9fc..f912ebe29445c0e79967bd72e56f786dbfa79266 100644

--- a/chrome/browser/metrics/variations/variations_service_unittest.cc

+++ b/chrome/browser/metrics/variations/variations_service_unittest.cc

@@ -91,7 +91,7 @@ std::string SerializeSeedBase64(const VariationsSeed& seed, std::string* hash) {

*hash = base::HexEncode(sha1.data(), sha1.size());

}

std::string base64_serialized_seed;

- EXPECT_TRUE(base::Base64Encode(serialized_seed, &base64_serialized_seed));

+ base::Base64Encode(serialized_seed, &base64_serialized_seed);

return base64_serialized_seed;

}