content/shell/browser/webkit_test_controller.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/webkit_test_controller.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/webkit_test_controller.cc

diff --git a/content/shell/browser/webkit_test_controller.cc b/content/shell/browser/webkit_test_controller.cc

index 8f458e7e3a3cc3111ad357706355b6ba69944189..3939669b419838c12ce16831effa3e7c107d8ff9 100644

--- a/content/shell/browser/webkit_test_controller.cc

+++ b/content/shell/browser/webkit_test_controller.cc

@@ -170,10 +170,9 @@ void WebKitTestResultPrinter::PrintEncodedBinaryData(

*output_ << "Content-Transfer-Encoding: base64\n";

std::string data_base64;

- const bool success = base::Base64Encode(

+ base::Base64Encode(

base::StringPiece(reinterpret_cast<const char*>(&data[0]), data.size()),

&data_base64);

- DCHECK(success);

*output_ << "Content-Length: " << data_base64.length() << "\n";

output_->write(data_base64.c_str(), data_base64.length());