chrome/browser/sync/profile_sync_service_harness.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_harness.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service_harness.cc

diff --git a/chrome/browser/sync/profile_sync_service_harness.cc b/chrome/browser/sync/profile_sync_service_harness.cc

index 695f27797bfcda737fbdf7805e5efac0946f4d1a..3bb1763e42dabaadad8eb01b3c605b66403c732a 100644

--- a/chrome/browser/sync/profile_sync_service_harness.cc

+++ b/chrome/browser/sync/profile_sync_service_harness.cc

@@ -929,13 +929,8 @@ bool ProfileSyncServiceHarness::MatchesOtherClient(

if (marker != partner_marker) {

if (VLOG_IS_ON(2)) {

std::string marker_base64, partner_marker_base64;

- if (!base::Base64Encode(marker, &marker_base64)) {

- NOTREACHED();

- }

- if (!base::Base64Encode(

- partner_marker, &partner_marker_base64)) {

- NOTREACHED();

- }

+ base::Base64Encode(marker, &marker_base64);

+ base::Base64Encode(partner_marker, &partner_marker_base64);

DVLOG(2) << syncer::ModelTypeToString(i.Get()) << ": "

<< profile_debug_name_ << " progress marker = "

<< marker_base64 << ", "