components/policy/core/common/cloud/resource_cache.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/resource_cache.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/cloud/resource_cache.cc

diff --git a/components/policy/core/common/cloud/resource_cache.cc b/components/policy/core/common/cloud/resource_cache.cc

index e527679aa4c650f36ea0246f3c12e28c42af7417..7b9e327acd75ca97ab849bf66b000209b3a400e6 100644

--- a/components/policy/core/common/cloud/resource_cache.cc

+++ b/components/policy/core/common/cloud/resource_cache.cc

@@ -21,8 +21,9 @@ namespace {

// which is safe to use as a file name on all platforms.

bool Base64Encode(const std::string& value, std::string* encoded) {

DCHECK(!value.empty());

- if (value.empty() || !base::Base64Encode(value, encoded))

+ if (value.empty())

return false;

+ base::Base64Encode(value, encoded);

base::ReplaceChars(*encoded, "+", "-", encoded);

base::ReplaceChars(*encoded, "/", "_", encoded);

return true;