chrome/browser/ui/webui/print_preview/print_preview_handler.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

index 4a72e478dd84e30105c951a1bcbaf934609f882b..ef640a8dba06b5fb1c7741cc3430b7fae8a78d54 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

@@ -1172,9 +1172,7 @@ void PrintPreviewHandler::SendCloudPrintJob(const base::RefCountedBytes* data) {

std::string raw_data(reinterpret_cast<const char*>(data->front()),

data->size());

std::string base64_data;

- if (!base::Base64Encode(raw_data, &base64_data)) {

- NOTREACHED() << "Base64 encoding PDF data.";

- }

+ base::Base64Encode(raw_data, &base64_data);

StringValue data_value(base64_data);

web_ui()->CallJavascriptFunction("printToCloud", data_value);