content/shell/renderer/webkit_test_runner.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/webkit_test_runner.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/webkit_test_runner.cc

diff --git a/content/shell/renderer/webkit_test_runner.cc b/content/shell/renderer/webkit_test_runner.cc

index 91535fd0b47365582d97a798726eccbe048337a3..e9b96aecddb5e65826004ae5a0ea8401b4df469e 100644

--- a/content/shell/renderer/webkit_test_runner.cc

+++ b/content/shell/renderer/webkit_test_runner.cc

@@ -292,8 +292,7 @@ WebURL WebKitTestRunner::localFileToDataURL(const WebURL& file_url) {

routing_id(), local_path, &contents));

std::string contents_base64;

- if (!base::Base64Encode(contents, &contents_base64))

- return WebURL();

+ base::Base64Encode(contents, &contents_base64);

const char data_url_prefix[] = "data:text/css:charset=utf-8;base64,";

return WebURL(GURL(data_url_prefix + contents_base64));

« no previous file with comments | « content/shell/browser/webkit_test_controller.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »