remoting/host/token_validator_factory_impl.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/token_validator_factory_impl.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/token_validator_factory_impl.cc

diff --git a/remoting/host/token_validator_factory_impl.cc b/remoting/host/token_validator_factory_impl.cc

index 3dd92456546b0875109b32e72f5a330566478575..d93df62e6201ffbe9b09788b3321cf4b03e50292 100644

--- a/remoting/host/token_validator_factory_impl.cc

+++ b/remoting/host/token_validator_factory_impl.cc

@@ -107,8 +107,7 @@ class TokenValidatorImpl

std::string nonce_bytes;

crypto::RandBytes(WriteInto(&nonce_bytes, kNonceLength + 1), kNonceLength);

std::string nonce;

- bool success = base::Base64Encode(nonce_bytes, &nonce);

- DCHECK(success);

+ base::Base64Encode(nonce_bytes, &nonce);

return "client:" + remote_jid + " host:" + local_jid + " nonce:" + nonce;

}

« no previous file with comments | « remoting/host/pin_hash.cc ('k') | remoting/protocol/auth_util.cc » ('j') | no next file with comments »