chrome/browser/bookmarks/bookmark_html_writer.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_html_writer.cc

diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc

index 3096166b5a744660d14fd1a406132a2a2c54f60d..6de025939e25cd8fd0eb7cdff85f5e6c897f89cc 100644

--- a/chrome/browser/bookmarks/bookmark_html_writer.cc

+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc

@@ -270,10 +270,9 @@ class Writer : public base::RefCountedThreadSafe<Writer> {

favicon_data.assign(reinterpret_cast<const char*>(data->front()),

data->size());

std::string favicon_base64_encoded;

- if (base::Base64Encode(favicon_data, &favicon_base64_encoded)) {

- GURL favicon_url("data:image/png;base64," + favicon_base64_encoded);

- favicon_string = favicon_url.spec();

- }

+ base::Base64Encode(favicon_data, &favicon_base64_encoded);

+ GURL favicon_url("data:image/png;base64," + favicon_base64_encoded);

+ favicon_string = favicon_url.spec();

}

if (!WriteIndent() ||

« no previous file with comments | « base/base64_unittest.cc ('k') | chrome/browser/chromeos/settings/device_settings_cache.cc » ('j') | no next file with comments »