chrome/browser/ui/ash/screenshot_taker.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/screenshot_taker.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/screenshot_taker.cc

diff --git a/chrome/browser/ui/ash/screenshot_taker.cc b/chrome/browser/ui/ash/screenshot_taker.cc

index fa63be5aef724570f35a0bdea9e60a2983bb5ee7..e5f9408605772ebe5c3541d41afca082d6bcbc07 100644

--- a/chrome/browser/ui/ash/screenshot_taker.cc

+++ b/chrome/browser/ui/ash/screenshot_taker.cc

@@ -71,10 +71,7 @@ void CopyScreenshotToClipboard(scoped_refptr<base::RefCountedString> png_data) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

std::string encoded;

- if (!base::Base64Encode(png_data->data(), &encoded)) {

- LOG(ERROR) << "Failed to encode base64";

- return;

- }

+ base::Base64Encode(png_data->data(), &encoded);

// Only cares about HTML because ChromeOS doesn't need other formats.

// TODO(dcheng): Why don't we take advantage of the ability to write bitmaps